eric-wang-1990 commented on code in PR #3588:
URL: https://github.com/apache/arrow-adbc/pull/3588#discussion_r2444660270
##########
csharp/src/Drivers/Databricks/DatabricksParameters.cs:
##########
@@ -254,6 +254,58 @@ public class DatabricksParameters : SparkParameters
/// Must be a positive integer value.
/// </summary>
public const string OperationStatusRequestTimeout =
"adbc.databricks.operation_status_request_timeout";
+
+ // Statement Execution API configuration parameters
+
+ /// <summary>
+ /// The protocol to use for statement execution.
+ /// Supported values:
+ /// - "thrift": Use Thrift/HiveServer2 protocol (default)
+ /// - "rest": Use Statement Execution REST API
+ /// </summary>
+ public const string Protocol = "adbc.databricks.protocol";
+
+ /// <summary>
+ /// Result disposition for Statement Execution API.
+ /// Supported values:
+ /// - "inline": Results returned directly in response (≤25 MiB)
+ /// - "external_links": Results via presigned URLs (≤100 GiB)
+ /// - "inline_or_external_links": Hybrid mode - server decides based
on size (default, recommended)
+ /// </summary>
+ public const string ResultDisposition =
"adbc.databricks.result_disposition";
Review Comment:
Should we name these SEA related properties with something like
adbc.databricks.rest.result_disposition
##########
csharp/src/Drivers/Databricks/StatementExecution/StatementExecutionModels.cs:
##########
@@ -0,0 +1,587 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+using System.Collections.Generic;
+using System.Text.Json.Serialization;
+
+namespace Apache.Arrow.Adbc.Drivers.Databricks.StatementExecution
+{
+ // Session Management Models
+
+ /// <summary>
+ /// Request to create a new session in Databricks.
+ /// </summary>
+ public class CreateSessionRequest
Review Comment:
Why do we need a CreateSessionRequest for SEA? I am not seeing a
CreateSession REST API here?
https://docs.databricks.com/api/workspace/statementexecution/executestatement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
