CurtHagenlocher commented on code in PR #3592:
URL: https://github.com/apache/arrow-adbc/pull/3592#discussion_r2445995417
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs:
##########
@@ -343,7 +343,7 @@ internal TCLIService.IAsync Client
internal async Task OpenAsync()
{
- await this.TraceActivity(async activity =>
+ await this.TraceActivityAsync(async activity =>
Review Comment:
The generic signature isn't doing us any favors here. Consider as a followup
modifying `IActivityTracerExtensions.TraceActivity` so that it throws a runtime
exception if `T` is a `Task`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
