kou commented on code in PR #47811:
URL: https://github.com/apache/arrow/pull/47811#discussion_r2450562430
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1118,6 +1118,11 @@ function(build_boost)
# This is for https://github.com/boostorg/container/issues/305
string(APPEND CMAKE_C_FLAGS " -Wno-strict-prototypes")
endif()
+ if(MSVC AND "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ARM64")
+ set(BOOST_CONTEXT_IMPLEMENTATION
+ winfib
+ CACHE STRING "" FORCE)
Review Comment:
Oh...
##########
.github/workflows/cpp_extra.yml:
##########
@@ -164,6 +164,19 @@ jobs:
continue-on-error: true
run: archery docker push ${{ matrix.image }}
+ windows:
+ needs: check-labels
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ name: ARM64 Windows 11 C++
Review Comment:
"C++" is redundant because this workflow is only for C++:
```suggestion
name: ARM64 Windows 11
```
##########
.github/workflows/cpp_extra.yml:
##########
@@ -164,6 +164,19 @@ jobs:
continue-on-error: true
run: archery docker push ${{ matrix.image }}
+ windows:
Review Comment:
```suggestion
msvc-arm64:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
