raulcd commented on code in PR #47915: URL: https://github.com/apache/arrow/pull/47915#discussion_r2454335044
########## cpp/src/arrow/CMakeLists.txt: ########## @@ -80,7 +80,7 @@ if(ARROW_WITH_ZSTD) endif() if(ARROW_ORC) - if(ORC_SOURCE STREQUAL "SYSTEM") + if(orc_SOURCE STREQUAL "SYSTEM") Review Comment: Not strictly related to this change but while taking a look on where are we defining `orc_SOURCE` here: https://github.com/apache/arrow/blob/8dd9eba99a69dbdf1d110cebf0bd349ee3ac7eda/cpp/cmake_modules/ThirdpartyToolchain.cmake#L91-L97 I came up with: https://github.com/apache/arrow/blob/8dd9eba99a69dbdf1d110cebf0bd349ee3ac7eda/cpp/cmake_modules/ThirdpartyToolchain.cmake#L113-L119 Shouldn't we do the same below changing `GLOG_SOURCE` for `glog_SOURCE`? https://github.com/apache/arrow/blob/8dd9eba99a69dbdf1d110cebf0bd349ee3ac7eda/cpp/src/arrow/CMakeLists.txt#L89-L91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
