HuaHuaY commented on code in PR #47775:
URL: https://github.com/apache/arrow/pull/47775#discussion_r2454499016
##########
cpp/src/parquet/page_index.h:
##########
@@ -86,6 +87,8 @@ class PARQUET_EXPORT ColumnIndex {
/// \brief List of repetition level histograms for each page concatenated
together.
virtual const std::vector<int64_t>& repetition_level_histograms() const = 0;
+
+ virtual const void* to_thrift() const = 0;
Review Comment:
I plan to remove `format::OffsetIndex` in `OffsetIndexImpl` in my first
commit, and add a new method `static inline format::PageLocation ToThrift(const
PageLocation&)` in `thrift_internal.h` to convert offset index to its thrift
format. But there was a `format::ColumnIndex` in `TypedColumnIndexImpl` which
is used to avoid copying some vectors.
@pitrou Do you think we should preserve the `ColumnIndex::to_thrift` method
or write a similar `static inline format::ColumnIndex ToThrift(const
TypedColumnIndexImpl<>&)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
