vustef commented on code in PR #7307:
URL: https://github.com/apache/arrow-rs/pull/7307#discussion_r2455083318
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -700,7 +708,11 @@ impl RowGroupMetaData {
}
/// Method to convert from Thrift.
- pub fn from_thrift(schema_descr: SchemaDescPtr, mut rg: RowGroup) ->
Result<RowGroupMetaData> {
+ pub fn from_thrift(
+ schema_descr: SchemaDescPtr,
+ mut rg: RowGroup,
+ first_row_number: Option<i64>,
Review Comment:
I merged main now and resolved these conflicts (next step is addressing the
API questions). @jkylling could we make `first_row_number` non-optional now?
Also now I think that it's not a breaking change, when it comes to metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
