etseidl commented on PR #8687: URL: https://github.com/apache/arrow-rs/pull/8687#issuecomment-3443587519
I think this one might fall under the "move the error to validation" category (see https://github.com/apache/arrow-rs/issues/6737#issuecomment-2551572811), but the current `ColumnMetaDataBuilder` doesn't provide much opportunity for that either. The public builders should be changed to do validation in the setters. Is this one the result of some testing or just a search for `assert`? If the former, then rather than this breaking change, perhaps add a `try_byte_range` or some such that returns `Result` and add a note that the existing `byte_range` may panic. If the latter, then we can probably let this alone for now and instead focus on fixing the builders for the `58.0.0` release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
