pepijnve commented on code in PR #8693:
URL: https://github.com/apache/arrow-rs/pull/8693#discussion_r2461017360


##########
arrow-select/src/filter.rs:
##########
@@ -300,6 +297,31 @@ impl FilterPredicate {
         filter_array(values, self)
     }
 
+    /// Returns a filtered [`RecordBatch`] containing only the rows that are 
selected by this
+    /// [`FilterPredicate`].
+    ///
+    /// This is the equivalent of calling [filter] on each column of the 
[`RecordBatch`].

Review Comment:
   I added some extra documentation on the convenience free standing functions 
related to FilterPredicate reuse. I'm not sure how useful it is to have 
circular documentation references from FilterPredicate back to those.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to