amoeba commented on code in PR #47916: URL: https://github.com/apache/arrow/pull/47916#discussion_r2461621876
########## .github/pull_request_template.md: ########## @@ -15,6 +15,16 @@ Please remove this line and the above text before creating your pull request. ### Are there any user-facing changes? +### Checklist + +- [ ] The PR's title follows existing conventions of the repository +- [ ] My code follows the general style and conventions of the codebase Review Comment: We don't have a good single reference for code style, but maybe linking directly to the C++ and Python development pages (which include style guidance) would be good? Generally, it'd be nice if as much of the contents of the PR template had links. ########## .github/pull_request_template.md: ########## @@ -15,6 +15,16 @@ Please remove this line and the above text before creating your pull request. ### Are there any user-facing changes? +### Checklist + +- [ ] The PR's title follows existing conventions of the repository Review Comment: Link would be good. ########## .github/pull_request_template.md: ########## @@ -15,6 +15,16 @@ Please remove this line and the above text before creating your pull request. ### Are there any user-facing changes? +### Checklist + +- [ ] The PR's title follows existing conventions of the repository +- [ ] My code follows the general style and conventions of the codebase Review Comment: ```suggestion - [ ] My code follows the general style and conventions of the codebase ([C++](https://arrow.apache.org/docs/developers/cpp/development.html), [Python](https://arrow.apache.org/docs/developers/python/development.html)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
