projjal commented on a change in pull request #10033:
URL: https://github.com/apache/arrow/pull/10033#discussion_r617519065
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -307,6 +306,37 @@ CAST_NUMERIC_FROM_STRING(double, arrow::DoubleType, FLOAT8)
#undef CAST_NUMERIC_FROM_STRING
+#define CAST_NUMERIC_FROM_VARBINARY(OUT_TYPE, ARROW_TYPE, TYPE_NAME)
\
+ GANDIVA_EXPORT
\
+ OUT_TYPE gdv_fn_cast##TYPE_NAME##_varbinary(int64_t context, const char*
data, \
Review comment:
Use a macro to use the same definition for both string and varbinary
inputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
