jonkeane commented on a change in pull request #10117:
URL: https://github.com/apache/arrow/pull/10117#discussion_r617519386
##########
File path: cpp/src/arrow/memory_pool.cc
##########
@@ -170,13 +170,8 @@ MemoryPoolBackend DefaultBackend() {
if (backend.has_value()) {
return backend.value();
}
-#ifdef ARROW_JEMALLOC
- return MemoryPoolBackend::Jemalloc;
-#elif defined(ARROW_MIMALLOC)
- return MemoryPoolBackend::Mimalloc;
-#else
- return MemoryPoolBackend::System;
-#endif
+ struct SupportedBackend default_backend = SupportedBackends().front();
+ return default_backend.backend;
Review comment:
Yup, I did test this locally to make sure, and it works like I expected
it to: mimalloc is default with no `ARROW_DEFAULT_MEMORY_POOL` set and also
with a `ARROW_DEFAULT_MEMORY_POOL` set that is not supported / non existent.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
