lidavidm commented on code in PR #47764:
URL: https://github.com/apache/arrow/pull/47764#discussion_r2464193410
##########
cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h:
##########
@@ -91,9 +91,15 @@ class FlightSQLOdbcV2RemoteTestBase : public
FlightSQLODBCRemoteTestBase {
void SetUp() override;
};
-static constexpr std::string_view kAuthorizationHeader = "authorization";
-static constexpr std::string_view kBearerPrefix = "Bearer ";
-static constexpr std::string_view kTestToken = "t0k3n";
+class FlightSQLOdbcEnvConnHandleRemoteTestBase : public
FlightSQLODBCRemoteTestBase {
+ protected:
+ void SetUp() override;
+ void TearDown() override;
+};
+
+static constexpr std::string_view authorization_header = "authorization";
+static constexpr std::string_view bearer_prefix = "Bearer ";
+static constexpr std::string_view test_token = "t0k3n";
Review Comment:
Can we keep to the naming scheme? kAuthorizationHeader etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
