lidavidm commented on code in PR #884:
URL: https://github.com/apache/arrow-java/pull/884#discussion_r2465613993
##########
vector/src/main/java/org/apache/arrow/vector/util/VectorAppender.java:
##########
@@ -698,4 +703,70 @@ public ValueVector visit(ExtensionTypeVector<?>
deltaVector, Void value) {
deltaVector.getUnderlyingVector().accept(underlyingAppender, null);
return targetVector;
}
+
+ @Override
+ public ValueVector visit(RunEndEncodedVector deltaVector, Void value) {
+ Preconditions.checkArgument(
+ typeVisitor.equals(deltaVector),
+ "The vector to append must have the same type as the targetVector
being appended");
Review Comment:
Hmm. I think the wording in this message is just terrible, on second glance.
We don't have to change them all, but I think the new one should say "The
deltaVector to append must have the same type as the targetVector"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
