paleolimbot opened a new pull request, #3623: URL: https://github.com/apache/arrow-adbc/pull/3623
This PR proposes a 1.2 spec addition `AdbcStatementRequestSchema()`. There are a few decisions here and while I put specific language in I think any version of these is still helpful: - I wrote this up as this best-effort (like the PyCapsule `requested_schema`). I think this is better for negotiation (e.g., the caller calls execute schema, requests a schema with all strings/binary/list columns as views, and the driver produces string/binary views but not list views because it doesn't implement those). A strict version is also useful and might generate better errors. - Maybe `struct ArrowSchema*` should be `const ArrowSchema*`. I'm not sure this matters (mostly the C struct will be populated specifically for this call and they are easy to copy). - No opinions on `RequestSchema` as the name if there's a better one The capability to do this is built in to the Postgres driver already for some types (the COPY reader was designed to always accept an arbitrary ArrowSchema, which we currently just infer before constructing the reader). Other 1.2 spec additions in https://github.com/apache/arrow-adbc/pull/3607 (which also contains the infrastructure for a new ADBC minor version). Closes #1514 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
