vegarsti commented on code in PR #8716:
URL: https://github.com/apache/arrow-rs/pull/8716#discussion_r2467016783
##########
arrow-cast/src/cast/run_array.rs:
##########
@@ -134,16 +134,8 @@ pub(crate) fn cast_to_run_end_encoded<K: RunEndIndexType>(
));
}
- // Partition the array to identify runs of consecutive equal values
- let partitions = partition(&[Arc::clone(cast_array)])?;
- let mut run_ends = Vec::new();
Review Comment:
Oh, great idea!
Side note: How did you profile this, using samply (it looks like), `cargo
build --profile profiling`, and ran e.g. a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
