willtemperley commented on code in PR #39:
URL: https://github.com/apache/arrow-swift/pull/39#discussion_r2468064709
##########
Arrow/Sources/Arrow/ArrowType.swift:
##########
@@ -165,14 +165,23 @@ public class ArrowTypeTimestamp: ArrowType {
}
}
-public class ArrowNestedType: ArrowType {
+public class ArrowTypeStruct: ArrowType {
let fields: [ArrowField]
public init(_ info: ArrowType.Info, fields: [ArrowField]) {
self.fields = fields
super.init(info)
}
}
+public class ArrowTypeList: ArrowType {
+ let elementType: ArrowType
+
+ public init(_ elementType: ArrowType) {
Review Comment:
I think this should take an ArrowField allowing specify nullability of the
primitive. From the spec:
"Any value in an array may be semantically null, whether primitive or nested
type."
https://arrow.apache.org/docs/format/Columnar.html#validity-bitmaps
Conventionally this field name is set to "item" for List types.
https://github.com/apache/arrow-rs/blob/main/arrow-schema/src/field.rs#L203C0-L220C0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
