raulcd commented on code in PR #47947: URL: https://github.com/apache/arrow/pull/47947#discussion_r2469110088
########## ci/conda_env_cpp.txt: ########## @@ -32,6 +31,7 @@ glog gmock>=1.10.0 google-cloud-cpp>=1.34.0 gtest>=1.10.0 +libboost-devel Review Comment: thanks for this! ########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -1191,17 +1191,21 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION # GH-34094 Older versions of Boost use the deprecated std::unary_function in # boost/container_hash/hash.hpp and support for that was removed in clang 16 set(ARROW_BOOST_REQUIRED_VERSION "1.81") -elseif(ARROW_BUILD_TESTS) - set(ARROW_BOOST_REQUIRED_VERSION "1.64") else() - set(ARROW_BOOST_REQUIRED_VERSION "1.58") + # CentOS 7 uses Boost 1.69. + set(ARROW_BOOST_REQUIRED_VERSION "1.69") endif() set(Boost_USE_MULTITHREADED ON) if(MSVC AND ARROW_USE_STATIC_CRT) set(Boost_USE_STATIC_RUNTIME ON) endif() # CMake 3.25.0 has 1.80 and older versions. +# +# We can remove this once we require CMake 3.30.0 or later because we +# enable CMP0167 "The FindBoost module is removed." +# https://cmake.org/cmake/help/latest/policy/CMP0167.html with CMake +# 3.30.0 or later. set(Boost_ADDITIONAL_VERSIONS Review Comment: I don't understand why we don't have to add "1.89.0" here. I understand that we will have to remove this once CMake >= 3.30.0 but from https://cmake.org/cmake/help/latest/module/FindBoost.html it doesn't seem like `1.89.9` should not be added to this list. Do you know why this is not required? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
