zeroshade commented on code in PR #551:
URL: https://github.com/apache/arrow-go/pull/551#discussion_r2470402471
##########
parquet/file/column_reader.go:
##########
@@ -38,6 +38,19 @@ const (
defaultPageHeaderSize = 16 * 1024
)
+// DictionaryState tracks the lifecycle of dictionary handling for a column
chunk
+type DictionaryState int
+
+const (
+ // DictNotRead: Dictionary page has not been read yet
+ DictNotRead DictionaryState = iota
+ // DictReadNotInserted: Dictionary page has been read and decoder
configured,
+ // but not yet inserted into Arrow builder (for Arrow Dictionary types
only)
+ DictReadNotInserted
+ // DictFullyProcessed: Dictionary has been read, configured, and
inserted into builder
+ DictFullyProcessed
+)
Review Comment:
my only critique is that we shouldn't export these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
