thisisnic commented on code in PR #47985:
URL: https://github.com/apache/arrow/pull/47985#discussion_r2470845079
##########
r/configure:
##########
@@ -83,7 +83,10 @@ UNAME=`uname -s`
# If in development mode, run the codegen script to render arrowExports.*
if [ "$ARROW_R_DEV" = "true" ] && [ -f "data-raw/codegen.R" ]; then
echo "*** Generating code with data-raw/codegen.R"
- ${R_HOME}/bin/Rscript data-raw/codegen.R
+ if ! ${R_HOME}/bin/Rscript data-raw/codegen.R; then
+ echo "*** ERROR: codegen.R failed"
+ exit 1
+ fi
Review Comment:
I was surprised codegen failing didn't cause the CI job to fail, but it'll
just use the existing (possibly outdated) files, so now at least we should
catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
