alamb commented on code in PR #8649:
URL: https://github.com/apache/arrow-rs/pull/8649#discussion_r2470961646
##########
arrow-schema/src/datatype_parse.rs:
##########
@@ -382,6 +448,13 @@ impl<'a> Parser<'a> {
Ok(DataType::Struct(Fields::from(fields)))
}
+ /// return and consume if the next token is `Token::Nullable`
+ fn nullable(&mut self) -> bool {
Review Comment:
Maybe calling this similarly to `parse` would make it clearer what it was
doing:
For example:
```suggestion
fn parse_opt_nullable(&mut self) -> bool {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
