asubiotto commented on code in PR #8735:
URL: https://github.com/apache/arrow-rs/pull/8735#discussion_r2472780895


##########
arrow-cast/src/cast/mod.rs:
##########
@@ -11866,4 +11910,129 @@ mod tests {
         // Verify the run-ends were cast correctly (run ends at 3, 6, 9)
         assert_eq!(run_array.run_ends().values(), &[3i64, 6i64, 9i64]);
     }
+
+    #[test]
+    fn test_cast_list_view_to_list() {

Review Comment:
   List to ListView should be pretty straightforward, but I think there are a 
couple interesting ListView to List cases if you haven't tested these yet:
   - ListView with out of order offsets (this is valid)
   - ListView with overlapping views so the inner child probably needs a `take` 
for expansion e.g. offsets=[0,0] sizes=[1,2]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to