CurtHagenlocher commented on code in PR #3650:
URL: https://github.com/apache/arrow-adbc/pull/3650#discussion_r2475372549
##########
csharp/src/Drivers/Databricks/Reader/CloudFetch/DownloadResult.cs:
##########
@@ -103,10 +103,14 @@ public void UpdateWithRefreshedLink(TSparkArrowResultLink
refreshedLink)
}
/// <inheritdoc />
- public void SetCompleted(Stream dataStream, long size)
+ public void SetCompleted(ReadOnlyMemory<byte> data, long size)
Review Comment:
With this change, we probably don't need to take `size` separately anymore.
That said, if any of these uncompressed buffers are more than 2 GB in size,
things are going to break in general due to CLR limitations. That's a much
larger topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
