pixelherodev commented on PR #556: URL: https://github.com/apache/arrow-go/pull/556#issuecomment-3465981758
I ran `go test -bench . -benchmem -benchtime 30s` before and after to highlight the variance better without running the test 20 times. Before: ``` BenchmarkIPC/Writer/codec=plain-24 6277569 6240 ns/op 8160 B/op 91 allocs/op BenchmarkIPC/Reader/codec=plain-24 6876433 5247 ns/op 6131 B/op 83 allocs/op BenchmarkIPC/Writer/codec=zstd-24 114764 324831 ns/op 2338736 B/op 150 allocs/op BenchmarkIPC/Reader/codec=zstd-24 1310571 28743 ns/op 25869 B/op 194 allocs/op BenchmarkIPC/Writer/codec=lz4-24 2930214 12186 ns/op 12905 B/op 134 allocs/op BenchmarkIPC/Reader/codec=lz4-24 3445965 10790 ns/op 10174 B/op 124 allocs/op ``` After: ``` BenchmarkIPC/Writer/codec=plain-24 6302840 5482 ns/op 8160 B/op 91 allocs/op BenchmarkIPC/Reader/codec=plain-24 7418485 4689 ns/op 5995 B/op 76 allocs/op BenchmarkIPC/Writer/codec=zstd-24 102850 346718 ns/op 2338731 B/op 150 allocs/op BenchmarkIPC/Reader/codec=zstd-24 1422286 25704 ns/op 25742 B/op 187 allocs/op BenchmarkIPC/Writer/codec=lz4-24 2921695 11956 ns/op 12880 B/op 134 allocs/op BenchmarkIPC/Reader/codec=lz4-24 3545550 10179 ns/op 9986 B/op 117 allocs/op ``` Both numbers are a bit worse like this, but more consistent; readers look to be consistently ~5-10% faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
