pitrou commented on code in PR #48005:
URL: https://github.com/apache/arrow/pull/48005#discussion_r2478681159
##########
cpp/src/parquet/column_io_benchmark.cc:
##########
@@ -196,16 +199,17 @@ static void BM_ReadInt64Column(::benchmark::State& state,
Repetition::type repet
int64_t stream_size = src->size();
int64_t data_size = int64_values.length() * sizeof(int64_t);
- std::vector<int64_t> values_out(state.range(1));
- std::vector<int16_t> definition_levels_out(state.range(1));
- std::vector<int16_t> repetition_levels_out(state.range(1));
+ std::vector<int64_t> values_out(kBatchSize);
+ std::vector<int16_t> definition_levels_out(kBatchSize);
+ std::vector<int16_t> repetition_levels_out(kBatchSize);
while (state.KeepRunning()) {
std::shared_ptr<Int64Reader> reader =
- BuildReader(src, state.range(1), codec, schema.get());
+ BuildReader(src, kNumValues, codec, schema.get());
Review Comment:
This is the fix: we were instantiating the ColumnReader with the read batch
size (`state.range(1)`) instead of the total number of values
(`state.range(0)`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
