hamilton-earthscope commented on PR #557:
URL: https://github.com/apache/arrow-go/pull/557#issuecomment-3468894108

   on `main`:
   ```
   go test -bench=BenchmarkTakeString -benchmem -benchtime=3x -run=^$ -timeout 
30m
   goos: darwin
   goarch: arm64
   pkg: github.com/apache/arrow-go/v18/arrow/compute
   cpu: Apple M3 Max
   BenchmarkTakeString/SmallBatch_ShortStrings-16                 3            
139750 ns/op           7163478 rows/sec       835890 B/op         198 allocs/op
   BenchmarkTakeString/MediumBatch_ShortStrings-16                3          
13052111 ns/op            766200 rows/sec     98296896 B/op        1762 
allocs/op
   BenchmarkTakeString/LargeBatch_ShortStrings-16                 3         
193090167 ns/op            258947 rows/sec     2746571538 B/op      9389 
allocs/op
   BenchmarkTakeString/XLargeBatch_ShortStrings-16                3         
564450403 ns/op            177164 rows/sec     11119508282 B/op    18947 
allocs/op
   BenchmarkTakeString/SmallBatch_MediumStrings-16                3           
3269042 ns/op            305968 rows/sec     21126634 B/op         826 allocs/op
   BenchmarkTakeString/MediumBatch_MediumStrings-16               3         
198658722 ns/op             50338 rows/sec     2055054277 B/op      8127 
allocs/op
   BenchmarkTakeString/LargeBatch_MediumStrings-16                3        
2286152306 ns/op             21871 rows/sec     52530632896 B/op    41554 
allocs/op
   BenchmarkTakeString/XLargeBatch_MediumStrings-16               3        
8208929458 ns/op             12182 rows/sec     210687783749 B/op           
83644 allocs/op
   BenchmarkTakeString/LargeBatch_ShortStrings_Large-16           3         
183346069 ns/op            272709 rows/sec     2746760874 B/op      9312 
allocs/op
   BenchmarkTakeString/XLargeBatch_MediumStrings_Large-16         3        
8180564000 ns/op             12224 rows/sec     210688177797 B/op           
83568 allocs/op
   BenchmarkTakeStringPartitionPattern-16                         3         
378207430 ns/op            132203 rows/sec     6315631330 B/op     14193 
allocs/op
   PASS
   ok      github.com/apache/arrow-go/v18/arrow/compute    81.473s
   ```
   
   
   this PR:
   ```
   go test -bench=BenchmarkTakeString -benchmem -benchtime=3x -run=^$ -timeout 
30m
   goos: darwin
   goarch: arm64
   pkg: github.com/apache/arrow-go/v18/arrow/compute
   cpu: Apple M3 Max
   BenchmarkTakeString/SmallBatch_ShortStrings-16                 3             
42167 ns/op          23920202 rows/sec        17906 B/op          44 allocs/op
   BenchmarkTakeString/MediumBatch_ShortStrings-16                3            
156903 ns/op          63869468 rows/sec       160456 B/op          44 allocs/op
   BenchmarkTakeString/LargeBatch_ShortStrings-16                 3            
760750 ns/op          65783472 rows/sec       805077 B/op          43 allocs/op
   BenchmarkTakeString/XLargeBatch_ShortStrings-16                3           
1148056 ns/op          87144906 rows/sec      1614917 B/op          43 allocs/op
   BenchmarkTakeString/SmallBatch_MediumStrings-16                3             
29931 ns/op          33707865 rows/sec        64749 B/op          42 allocs/op
   BenchmarkTakeString/MediumBatch_MediumStrings-16               3            
229431 ns/op          43689299 rows/sec       562298 B/op          42 allocs/op
   BenchmarkTakeString/LargeBatch_MediumStrings-16                3            
705195 ns/op          70951339 rows/sec      2812080 B/op          42 allocs/op
   BenchmarkTakeString/XLargeBatch_MediumStrings-16               3           
1352417 ns/op          73981205 rows/sec      5612592 B/op          42 allocs/op
   BenchmarkTakeString/LargeBatch_ShortStrings_Large-16           3            
571167 ns/op          87591241 rows/sec      1001650 B/op          42 allocs/op
   BenchmarkTakeString/XLargeBatch_MediumStrings_Large-16         3           
1353181 ns/op          73933345 rows/sec      6014005 B/op          42 allocs/op
   BenchmarkTakeStringPartitionPattern-16                         3            
650014 ns/op          76983953 rows/sec      1312954 B/op          42 allocs/op
   PASS
   ok      github.com/apache/arrow-go/v18/arrow/compute    0.585s
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to