alamb commented on code in PR #8755:
URL: https://github.com/apache/arrow-rs/pull/8755#discussion_r2481336757
##########
parquet/tests/arrow_reader/predicate_cache.rs:
##########
@@ -52,8 +52,7 @@ async fn test_default_read() {
#[tokio::test]
async fn test_async_cache_with_filters() {
let test =
ParquetPredicateCacheTest::new().with_expected_records_read_from_cache(49);
- let async_builder = test.async_builder().await;
- let async_builder = test.add_project_ab_and_filter_b(async_builder);
+ let async_builder =
test.async_builder().await.add_project_ab_and_filter_b();
Review Comment:
This is the key change -- move the logic to add specific filters to an
extension trait rather than a methog on the `ParquetPredicateCacheTest` test
fixture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
