mapleFU commented on code in PR #8756:
URL: https://github.com/apache/arrow-rs/pull/8756#discussion_r2482281406


##########
parquet/src/file/serialized_reader.rs:
##########
@@ -471,6 +455,47 @@ pub(crate) fn decode_page(
     Ok(result)
 }
 
+/// Decompressed the specified buffer, starting from the specified offset, 
using
+/// the provided decompressor if available and applicable. If the buffer is not
+/// compressed, it will be returned as is.

Review Comment:
   The code looks good to me but the I don't know if the comment "not 
compressed" can be replaced, if `decompress_buffer` is called and 
`decompressed_size == 0` , seems that it generally means something like "this 
page only have levels, but not have non-null values"? ( Point me out if I'm 
wrong)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to