tswast opened a new pull request, #48018:
URL: https://github.com/apache/arrow/pull/48018

   ### Rationale for this change
   
   I'm working on a system that supports picosecond precision timestamps, and 
I'm interested in interoperability with the Arrow ecosystem. See 
https://github.com/apache/arrow/issues/47848
   
   ### What changes are included in this PR?
   
   This PR only adds the new enum value TimeUnit::PICO. This enum value is 
unused for now, but I plan to introduce a timestamp128 type in the future which 
supports this unit type.
   
   ### Are these changes tested?
   
   I have updated and run the C++ test suite.
   
   ```
   root@dc20d61d62a2:/github.com/apache/arrow/cpp/build# 
   ...
   100% tests passed, 0 tests failed out of 91
   
   Label Time Summary:
   arrow-compute-tests    = 128.41 sec*proc (15 tests)
   arrow-tests            =  65.74 sec*proc (38 tests)
   arrow_acero            = 120.93 sec*proc (14 tests)
   arrow_dataset          = 103.61 sec*proc (13 tests)
   arrow_substrait        =   0.98 sec*proc (1 test)
   filesystem             =   1.97 sec*proc (1 test)
   parquet-tests          =  88.40 sec*proc (10 tests)
   unittest               = 508.07 sec*proc (91 tests)
   
   Total Test time (real) =  50.20 sec
   ```
   
   ### Are there any user-facing changes?
   
   **This PR includes breaking changes to public APIs.**
   
   Adding a new enum variable did break some tests that assumed that all 
TimeUnit::values() are valid for use in the timestamp (64-bit) data type.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to