BlakeOrth commented on code in PR #8222:
URL: https://github.com/apache/arrow-rs/pull/8222#discussion_r2482749480
##########
parquet/src/basic.rs:
##########
@@ -850,8 +859,11 @@ impl From<parquet::LogicalType> for LogicalType {
parquet::LogicalType::UUID(_) => LogicalType::Uuid,
parquet::LogicalType::FLOAT16(_) => LogicalType::Float16,
parquet::LogicalType::VARIANT(_) => LogicalType::Variant,
- parquet::LogicalType::GEOMETRY(_) => LogicalType::Geometry,
- parquet::LogicalType::GEOGRAPHY(_) => LogicalType::Geography,
+ parquet::LogicalType::GEOMETRY(t) => LogicalType::Geometry { crs:
t.crs },
+ parquet::LogicalType::GEOGRAPHY(t) => LogicalType::Geography {
+ crs: t.crs,
+ algorithm: t.algorithm,
+ },
Review Comment:
I was reviewing this PR/comments carefully and at first glance this really
caught me off guard:
> do a small CRS transform here
I found myself asking "why would I ever need to reproject geometries here?"
Nope, just a transformation of the CRS string itself :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
