tustvold commented on code in PR #8733:
URL: https://github.com/apache/arrow-rs/pull/8733#discussion_r2483678349
##########
parquet/src/column/reader.rs:
##########
@@ -541,6 +626,44 @@ where
}
}
+ fn try_create_synthetic_page(&mut self, metadata: Option<PageMetadata>) ->
Result<()> {
+ if self.descr.max_rep_level() != 0 {
+ return Err(general_err!(
+ "cannot synthesise sparse page for column with repetition
levels ({message})"
+ ));
+ }
+
+ if self.descr.max_def_level() == 0 {
+ return Err(general_err!(
+ "cannot synthesise sparse page for required column ({message})"
+ ));
+ }
Review Comment:
I think this would mean we error if we try to pushdown on a column with
either repetition levels or a required column - this seems like quite a major
regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
