justing-bq commented on code in PR #48021:
URL: https://github.com/apache/arrow/pull/48021#discussion_r2487429966
##########
cpp/src/arrow/flight/sql/odbc/odbc_api.cc:
##########
@@ -906,7 +906,7 @@ SQLRETURN SQLTables(SQLHSTMT stmt, SQLWCHAR* catalog_name,
SQLSMALLINT schema_name_length, SQLWCHAR* table_name,
SQLSMALLINT table_name_length, SQLWCHAR* table_type,
SQLSMALLINT table_type_length) {
- ARROW_LOG(DEBUG) << "SQLTablesW called with stmt: " << stmt
+ ARROW_LOG(DEBUG) << "SQLTables called with stmt: " << stmt
<< ", catalog_name: " << static_cast<const
void*>(catalog_name)
Review Comment:
Done.
##########
cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc:
##########
@@ -0,0 +1,602 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#include "arrow/flight/sql/odbc/tests/odbc_test_suite.h"
+
+#include "arrow/flight/sql/odbc/odbc_impl/platform.h"
+
+#include <sql.h>
+#include <sqltypes.h>
+#include <sqlucode.h>
+
+#include <gtest/gtest.h>
+
+namespace arrow::flight::sql::odbc {
+
+template <typename T>
+class TablesTest : public T {};
+
+class TablesMockTest : public FlightSQLODBCMockTestBase {};
+class TablesRemoteTest : public FlightSQLODBCRemoteTestBase {};
+using TestTypes = ::testing::Types<TablesRemoteTest, TablesMockTest>;
+TYPED_TEST_SUITE(TablesTest, TestTypes);
+
+template <typename T>
+class TablesOdbcV2Test : public T {};
+
+using TestTypesOdbcV2 =
+ ::testing::Types<FlightSQLOdbcV2MockTestBase,
FlightSQLOdbcV2RemoteTestBase>;
+TYPED_TEST_SUITE(TablesOdbcV2Test, TestTypesOdbcV2);
+
+namespace {
+// Helper Functions
+
+std::wstring GetStringColumnW(SQLHSTMT stmt, int colId) {
Review Comment:
Moved to odbc_test_suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
