GeorgeLeePatterson commented on PR #320: URL: https://github.com/apache/arrow-js/pull/320#issuecomment-3481999116
@kylebarron It took me a minute, but I was able to track down how the integration tests work for this repo. I'm sure you already know this, but they are defined in the archery tests in arrow. The problem there is the tests in question are skipped for JS (understandably so). What I did instead was create a branch on my fork and created a simple python script that generates the artifacts we need (ie json data and arrow files), then a validation script using arrow-js to read that data, obviously using the new types. All passed green, it is working well. You can pull down the branch and try for yourself, but I also included the results in the directory. As another note, funny enough the reason why I'm making all of these PRs is because I'm building an application and realized these types weren't supported! So I have personal motivation for seeing these merged as well. But more importantly, I have been using my local copy and running my application against it, which is full integration from Rust => JS. So from my end, I have verified these all work well. But hopefully the other branch can make that explicit. Happy to provide anything else if I missed the boat here, I wasn't sure exactly which direction to go. I appreciate the follow up, will keep an eye out for next steps. **Branch:** `integration-test-binaryview-utf8view` **Link:** [integration-test-binaryview-utf8view]( https://github.com/GeorgeLeePatterson/arrow-js/tree/integration-test-binaryview-utf8view/integration_tests/binaryview_utf8view) The tests generate BinaryView/Utf8View data using PyArrow and validate that arrow-js can correctly read the Arrow IPC files, including: - Inline data (≤12 bytes) and out-of-line data (>12 bytes) - Variadic buffer handling - Null/empty values - UTF-8 decoding including Unicode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
