etseidl commented on issue #8783:
URL: https://github.com/apache/arrow-rs/issues/8783#issuecomment-3488054634
Calling `ColumnDescriptor::logical_type` eventually leads to
`BasicTypeInfo::logical_type`
```rust
pub fn logical_type(&self) -> Option<LogicalType> {
// Unlike ConvertedType, LogicalType cannot implement Copy, thus we
clone it
self.logical_type.clone()
}
```
One big change in #8530 to `LogicalType` was fleshing out the `Variant`,
`Geography`, and `Geometry` variants, as well as adding `_Unknown`. Given that
the geo types include strings, I don't know if `clone` got way more expensive.
I don't know why `logical_type` returns a copy anyway...a ref would be
better, but that would be a breaking change.
I'll try adding a `logical_type_ref` and see if that helps.
Could someone (@alamb 👀) give me the Cargo foo necessary to use a branch of
parquet in tpchgen-rs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
