msathis commented on a change in pull request #22:
URL: https://github.com/apache/arrow-datafusion/pull/22#discussion_r618517647



##########
File path: ballista/ui/scheduler/.dockerignore
##########
@@ -0,0 +1,3 @@
+node_modules
+build
+.dockerignore

Review comment:
       Not necessarily. Just avoids copying it while building the image. Adding 
it or not adding it doesn't make big difference. But this link 
https://codefresh.io/docker-tutorial/not-ignore-dockerignore-2/ suggests to not 
ignore it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to