amoeba commented on code in PR #3686:
URL: https://github.com/apache/arrow-adbc/pull/3686#discussion_r2492541650
##########
ci/scripts/python_util.sh:
##########
@@ -180,6 +180,8 @@ import $component.dbapi
# --import-mode required, else tries to import from the source dir
instead of installed package
# set env var so that we don't skip tests if we somehow accidentally
installed pyarrow
- env ADBC_NO_SKIP_TESTS=1 python -m pytest -vvx --import-mode append
"${test_files[@]}"
+ # GH-3679: Don't prefix with 'env' command because env on macOS is
+ # "restricted" and strips DYLD_LIBRARY_PATH
+ ADBC_NO_SKIP_TESTS=1 python -m pytest -vvx --import-mode append
"${test_files[@]}"
Review Comment:
For reviewers, I think using `env` as we were is slightly more portable and
I'm not sure what this might break. Would it be safer to export it as a
separate command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
