christianbudgetthuis opened a new issue, #529:
URL: https://github.com/apache/arrow-rs-object-store/issues/529

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   When using the from_env function of the object store builders, environmental 
variables are expected to be upper-case, as is coventional. They are then 
converted to lower-case to be able to parse them as configuration options (see 
https://github.com/apache/arrow-rs-object-store/blob/1b8ecc7f41eab2a3c2c373f1c2fe21bebe391727/src/azure/builder.rs#L517).
   
   However, when using parse_url_opts the input is _not_ converted to 
lower-case (see 
https://github.com/apache/arrow-rs-object-store/blob/1b8ecc7f41eab2a3c2c373f1c2fe21bebe391727/src/parse.rs#L146)
 but, of course, still needs to be lower-case as this is what the parse 
function expects. The documentation even recommends passing std::env::vars() to 
the parse_url_opts function, which does not work as expected if you are using 
upper-case environmental variables.
   
   **Describe the solution you'd like**
   Make parse_url_opts work with uppercase env. var names, e.g. add 
to_ascii_lowercase in the builder macro.
   
   **Describe alternatives you've considered**
   Add a note in the documentation that the configuration options need to be 
lower-case for parse_url_opts and uppercase when using from_env() functions for 
concrete object stores.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to