mbrobbel commented on PR #8786: URL: https://github.com/apache/arrow-rs/pull/8786#issuecomment-3491929441
> Thanks @mbrobbel and @alamb! > > > I wonder if we should add a comment to LogicalType that it isn't trivially copy'able (and remove the Copy in later breaking release)? > > I did add a note to the getters that the value is cloned. I just wonder do we want to deprecate the cloning getters? It would be nice if eventually `logical_type()` returned `Option<&LogicalType>` and we could remove `logical_type_ref()`. +1 for `logical_type() -> Option<&LogicalType>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
