alamb commented on PR #8715:
URL: https://github.com/apache/arrow-rs/pull/8715#issuecomment-3492767275
> @alamb here's a proposal for the API implemented at this moment in this PR:
>
> ```
> let file = File::open(path).unwrap();
> let row_number_field = Field::new("row_number", ArrowDataType::Int64,
false).with_extension_type(RowNumber);
> let options =
ArrowReaderOptions::new().with_virtual_columns(vec![row_number_field]);
> let reader = ParquetRecordBatchReaderBuilder::try_new_with_options(file,
options)
> .unwrap()
> .build()
> .expect("Could not create reader");
> reader
> .collect::<Result<Vec<_>, _>>()
> .expect("Could not read")
> ```
> ```
I think that seems like a reasonable API to me -- as I mentioned on the
call, I think we should get some high level doc string tests that show how this
would work. I can't honestly remember what the difference between ReaderOptions
and ReaderProperties are (and why they are different).
As we discussed, I will try and review this PR carefully later today or
tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
