mapleFU commented on code in PR #8764:
URL: https://github.com/apache/arrow-rs/pull/8764#discussion_r2496764502
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -398,6 +396,8 @@ pub(crate) fn decode_page(
let decompressed_size = uncompressed_page_size - offset;
let mut decompressed = Vec::with_capacity(uncompressed_page_size);
decompressed.extend_from_slice(&buffer[..offset]);
+ // decompressed size of zero corresponds to a page with only null
values
+ // see
https://github.com/apache/parquet-format/blob/master/README.md#data-pages
Review Comment:
> However, my understanding of this comment is that it is trying to say that
there are no non-null values
Current comment is ok for me, I wonder would:
```
// decompressed size of zero corresponds to a page with no non-null values
```
Be better, since this also cover the case that `num_rows == 0` => `
num_values == 0 && num_nulls == 0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
