scovich commented on PR #8791: URL: https://github.com/apache/arrow-rs/pull/8791#issuecomment-3497537488
> > Seems fine, but shouldn't the existing `impl Deref` (L130 below) transparently provide access to [slice.is_empty](https://doc.rust-lang.org/std/primitive.slice.html#method.is_empty)? (c.f. [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=cef030da8ed2b5c7f192723f7e6fe9c3)) > > I think having an explicit method is probably still helpful even if it is strictly unecessary I'm certainly not against it, but I do wonder if there's ever a time where the slice `is_empty` would be inaccessible? I normally see doubled up methods when a trait is involved, useful because the trait isn't necessarily in scope for all callers. Update: [Vec::is_empty](https://doc.rust-lang.org/std/vec/struct.Vec.html#method.is_empty) exists, so there's definitely precedent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
