lidavidm commented on a change in pull request #10134:
URL: https://github.com/apache/arrow/pull/10134#discussion_r618744791
##########
File path: cpp/src/arrow/dataset/file_csv_test.cc
##########
@@ -36,7 +37,21 @@
namespace arrow {
namespace dataset {
-class TestCsvFileFormat : public testing::TestWithParam<Compression::type> {
+class ArrowCsvWriterMixin {
Review comment:
I originally tried with abstract methods, but then because of the
inheritance tree, you'd have to re-implement them in the AbcFileFormatTest and
in the AbcFileFormatScanTest fixtures (I had issues when trying to just have
the latter inherit the former). Probably there is some combination of
superclasses and interfaces that'll make it work but at that point I decided a
template was the lesser evil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
