pixelherodev commented on PR #322: URL: https://github.com/apache/arrow-go/pull/322#issuecomment-3500498861
> One other thought, though: if we're already using memory.DefaultAllocator, the Go allocator, Free is a no-op. We shouldn't even need the cleanups, _or_ the release/retain. IMO it almost makes more sense to move the AddCleanup logic _into memory.Allocator_, and not invoke it at _all_ for the Go allocator. > > That, combined with Retain/Release being disabled, would allow users of the _default allocator_ to not be paying overhead for special cases - does that design make sense? Bonus: Cleanups are 16 bytes; this avoids an additional 16 bytes for each Buffer for the Go allocator, which will _never use them._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
