vustef commented on code in PR #8715:
URL: https://github.com/apache/arrow-rs/pull/8715#discussion_r2503548238
##########
parquet/src/arrow/schema/complex.rs:
##########
@@ -229,6 +244,20 @@ impl Visitor {
}
}
+ if rep_level == 0 && def_level == 0 {
+ for virtual_column in self.virtual_columns {
+ // Ensure this is actually a virtual column
+ assert!(
+ super::virtual_type::is_virtual_column(virtual_column),
+ "Field '{}' is not a virtual column. Virtual columns must
have extension type names starting with 'arrow.virtual.'",
+ virtual_column.name()
+ );
+ child_fields.push(virtual_column.clone());
+ let child = convert_virtual_field(virtual_column, rep_level,
def_level)?;
Review Comment:
I made changes to this with
https://github.com/apache/arrow-rs/pull/8715/commits/3933d8e109144726a125918728178a9918c3bb5e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
