amoeba commented on PR #3693: URL: https://github.com/apache/arrow-adbc/pull/3693#issuecomment-3504680798
Hi @if0ne, thanks for the PR. I think you're right. Marking the deps as optional without an enabling feature doesn't seem right. Marking this as optional goes back to https://github.com/apache/arrow-adbc/commit/92c26ec6283b8dad394579ec3258fbc3986b0281. The intention may have been to make the ADBC Driver Manifest support optional on Windows but it would make more sense to do that as a feature flag. @eitsupi do you want to take a look here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
