justing-bq commented on code in PR #48056:
URL: https://github.com/apache/arrow/pull/48056#discussion_r2505753242
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_statement_get_tables.cc:
##########
Review Comment:
A string copy is still necessary for the sake of trimming the string.
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_statement_get_tables.cc:
##########
@@ -23,11 +23,21 @@
#include "arrow/flight/sql/odbc/odbc_impl/record_batch_transformer.h"
#include "arrow/flight/sql/odbc/odbc_impl/util.h"
#include "arrow/flight/types.h"
+#include "arrow/util/string.h"
namespace arrow::flight::sql::odbc {
using arrow::Result;
+static void AddTableType(std::string& table_type, std::vector<std::string>&
table_types) {
+ std::string trimmed_type = arrow::internal::TrimString(table_type);
+
+ // Only put the string if the trimmed result is non-empty
+ if (!trimmed_type.empty()) {
+ table_types.emplace_back(trimmed_type);
Review Comment:
Move added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
