pfparsons commented on code in PR #48009:
URL: https://github.com/apache/arrow/pull/48009#discussion_r2507069218
##########
python/pyarrow/_parquet_encryption.pyx:
##########
@@ -402,7 +411,9 @@ cdef class CryptoFactory(_Weakrefable):
def file_encryption_properties(self,
KmsConnectionConfig kms_connection_config,
- EncryptionConfiguration encryption_config):
+ EncryptionConfiguration encryption_config,
+ parquet_file_path="",
Review Comment:
Thanks, yes I did not like this either. I've changed the default to None
for both CryptoFactory file_{en,de}cryption_properties methods.
My initial inclination to use empty string was based on following the
defaults defined in
[CryptoFactory.h](https://github.com/apache/arrow/blob/cd23a765442bdbaaef43d0e4b239094fb01e37ae/cpp/src/parquet/encryption/crypto_factory.h#L112)
- and handled in
[file_system_key_material_store::Make](https://github.com/apache/arrow/blob/cd23a765442bdbaaef43d0e4b239094fb01e37ae/cpp/src/parquet/encryption/file_system_key_material_store.cc#L45)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
