alamb commented on code in PR #8782:
URL: https://github.com/apache/arrow-rs/pull/8782#discussion_r2508194551
##########
arrow-select/src/filter.rs:
##########
@@ -250,6 +243,20 @@ impl FilterBuilder {
self
}
+ /// Determines if calling [FilterBuilder::optimize] is beneficial for the
given type even when
+ /// filtering just a single array.
Review Comment:
I think it would help to add a little more context here
```suggestion
/// Determines if calling [FilterBuilder::optimize] is beneficial for
the given type even when
/// filtering just a single array.
///
/// Optimizaton will be beneficial if there is more than one child array
/// (e.g. a StructArray with multiple fields)
##########
arrow-select/src/filter.rs:
##########
@@ -230,7 +223,7 @@ impl FilterBuilder {
}
}
- /// Compute an optimised representation of the provided `filter` mask that
can be
+ /// Compute an optimized representation of the provided `filter` mask that
can be
Review Comment:
100% for consistent (american) spelling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
