jhrotko commented on code in PR #903: URL: https://github.com/apache/arrow-java/pull/903#discussion_r2510967933
########## vector/src/main/java/org/apache/arrow/vector/FixedSizeExtensionType.java: ########## Review Comment: This one is a bit tricky. For `ValueVectors` that are not an extension type and have a fixed width ex.: `FixedSizeBinaryVector.java`, they extend from `BaseFixedWidthVector` which is an abstract class with the method `getTypeWidth`. While Extension Type Vectors extend from abstract class`ExtensionTypeVector` hence cannot extend from the `BaseFixedWidthVector` class. In some instances ex.: `UuidVector` it would be nice to have a way to calculate the (fixed) width of the vector directly with no major differences from `BaseFixedWidthVector`. This Interface was introduced to help solve this issue. In our case, we have other Extended vectors that do not have a fixed width. We could add this method to `ExtensionTypeVector` although not all types have a fixed width necessarily. So it would be nice to use types for this validation instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
