zeroshade commented on code in PR #548:
URL: https://github.com/apache/arrow-go/pull/548#discussion_r2511255615


##########
parquet/pqarrow/file_writer.go:
##########
@@ -111,11 +115,27 @@ func (fw *FileWriter) NewRowGroup() {
 func (fw *FileWriter) NewBufferedRowGroup() {
        if fw.rgw != nil {
                fw.rgw.Close()
+               fw.totalCompressedBytes += fw.rgw.TotalCompressedBytes()
+               fw.totalBytesWritten += fw.rgw.TotalBytesWritten()

Review Comment:
   I was referring to the `Close` method in `file/file_writer.go` specifically, 
inside of `FlushWithFooter`. Currently when we close the file, we'll cover all 
of the bytes *except* for the metadata footer which is written at the end of 
the file. Make sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to