alinaliBQ commented on code in PR #48054:
URL: https://github.com/apache/arrow/pull/48054#discussion_r2512380317
##########
.github/workflows/cpp.yml:
##########
@@ -311,6 +311,7 @@ jobs:
ARROW_FLIGHT: ON
ARROW_FLIGHT_SQL: ON
ARROW_FLIGHT_SQL_ODBC: ON
+ ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON
Review Comment:
TODO: after ODBC can build in MSVC
https://github.com/apache/arrow/pull/48067, need to add
`ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON` in MSVC CI. Leaving this change here for
now. Rest of PR can be reviewed.
##########
cpp/src/arrow/flight/sql/odbc/install/arrow-wix-banner.bmp:
##########
Review Comment:
This is an image of Arrow banner
##########
.gitignore:
##########
@@ -107,3 +107,6 @@ java/.mvn/.develocity/
# rat
filtered_rat.txt
rat.txt
+
+# rc
+*.rc
Review Comment:
This is for ODBC dll
##########
cpp/CMakeLists.txt:
##########
Review Comment:
For installer to be able to select different components, we needed to add
`COMPONENT` to other parts of Arrow cpp that gets build with ODBC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
